Merge pull request #110 from thatblindgeye/css-foundations

Fix issue for users with color blindness
This commit is contained in:
Eric Olkowski 2022-02-09 16:56:18 -05:00 committed by GitHub
commit 4690cdaf31
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 21 additions and 25 deletions

View File

@ -1,7 +1,7 @@
# CSS Methods
This final exercise for CSS Foundations is going to give you a closer look at the cascade, in particular specificity and rule order. Both the HTML and CSS files are filled out for you, so instead of adding rules yourself, you will simply be editing what is provided.
There are a few elements that have some sort of specificity or rule order issue in the provided CSS file. It's up to you to figure out what issue is affecting an element, and how to fix it. You can edit the CSS file by adding or removing selectors or moving stuff around, but you should not edit the HTML file or any of the actual style declarations in the CSS.
There are a few elements that have some sort of specificity or rule order issue in the provided CSS file. It's up to you to figure out what issue is affecting an element, and how to fix it. You can edit the CSS file by adding, removing, or editing selectors for a declaration block, or by moving declaration blocks around. **You should not edit the HTML file or any of the actual styles in the CSS**.
There are multiple ways to solve this exercise, and we did our best to include all of the possible solutions for each element.

Binary file not shown.

Before

Width:  |  Height:  |  Size: 48 KiB

After

Width:  |  Height:  |  Size: 69 KiB

View File

@ -8,15 +8,15 @@
<link rel="stylesheet" href="style.css">
</head>
<body>
<p class="para">I'm just a simple paragraph!</p>
<p class="para small-para">I'm a smaller paragraph!</p>
<p class="para">I'm just a paragraph with red text!</p>
<p class="para small-para">I'm a smaller paragraph, also with red text!</p>
<button id="confirm-button" class="button confirm">Confirm</button>
<button id="cancel-button" class="button cancel">Cancel</button>
<div class="text">I'm not related to those divs down there.</div>
<div class="text">I have a child!
<div class="text child">My ancestor is so embarrassing.</div>
<div class="text">I'm a div with green text!</div>
<div class="text">I'm a div with green text and a child div!
<div class="text child">I'm a smaller child div with red text.</div>
</div>
</body>
</html>

View File

@ -8,14 +8,14 @@
}
.button {
background-color: #ffc0cb;
color: black;
background-color: rgb(255, 255, 255);
color: rgb(0, 0, 0);
font-size: 20px;
}
div.text {
color: green;
font-size: 28px;
font-size: 22px;
}
/* SOLUTION */
@ -24,7 +24,7 @@ div.text {
For the following rule, we removed it from its original position in the file:
.small-para {
font-size: 12px;
font-size: 14px;
}
Then we placed it after the .para selector, taking advantage of the rule order since both selectors have the same specificity.
@ -37,7 +37,7 @@ div.text {
*/
.small-para {
font-size: 12px;
font-size: 14px;
}
/*
@ -46,7 +46,6 @@ div.text {
.confirm {
background: green;
color: white;
font-size: 20px;
font-weight: bold;
}
@ -57,7 +56,6 @@ div.text {
.button.confirm {
background: green;
color: white;
font-size: 20px;
font-weight: bold;
}
*/
@ -65,7 +63,6 @@ div.text {
#confirm-button {
background: green;
color: white;
font-size: 20px;
font-weight: bold;
}
@ -90,4 +87,4 @@ div.text {
div .child {
color: red;
font-size: 14px;
}
}

View File

@ -8,15 +8,15 @@
<link rel="stylesheet" href="solution.css">
</head>
<body>
<p class="para">I'm just a simple paragraph!</p>
<p class="para small-para">I'm a smaller paragraph!</p>
<p class="para">I'm just a paragraph with red text!</p>
<p class="para small-para">I'm a smaller paragraph, also with red text!</p>
<button id="confirm-button" class="button confirm">Confirm</button>
<button id="cancel-button" class="button cancel">Cancel</button>
<div class="text">I'm not related to those divs down there.</div>
<div class="text">I have a child!
<div class="text child">My ancestor is so embarrassing.</div>
<div class="text">I'm a div with green text!</div>
<div class="text">I'm a div with green text and a child div!
<div class="text child">I'm a smaller child div with red text.</div>
</div>
</body>
</html>

View File

@ -4,7 +4,7 @@
}
.small-para {
font-size: 12px;
font-size: 14px;
}
.para {
@ -14,13 +14,12 @@
.confirm {
background: green;
color: white;
font-size: 20px;
font-weight: bold;
}
.button {
background-color: #ffc0cb;
color: black;
background-color: rgb(255, 255, 255);
color: rgb(0, 0, 0);
font-size: 20px;
}
@ -31,5 +30,5 @@
div.text {
color: green;
font-size: 28px;
font-size: 22px;
}