From 38c97c00b9db6a53dd1d9f4caa1da0790fd5076f Mon Sep 17 00:00:00 2001 From: scheals Date: Sun, 23 Jan 2022 21:13:03 +0100 Subject: [PATCH 1/3] Add hint about cards requiring defined space --- flex/07-flex-layout-2/README.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/flex/07-flex-layout-2/README.md b/flex/07-flex-layout-2/README.md index 8c9598a..3c7316b 100644 --- a/flex/07-flex-layout-2/README.md +++ b/flex/07-flex-layout-2/README.md @@ -6,8 +6,9 @@ As with the previous exercise, we've left a little more for you to do. ### Hints - You will need to change the flex-direction to push the footer down. -- You will need to add some divs as containers to get things to line up correctly. +- You will need to add some divs as containers to get things to line up correctly. - `flex-wrap` will help get the cards aligned correctly. +- Make sure cards know how much space they should take for `flex-wrap` to work correctly. ## Desired outcome From 2d36af0848a4becad4e5ea23f7c29367ab32516e Mon Sep 17 00:00:00 2001 From: scheals <95084627+scheals@users.noreply.github.com> Date: Sun, 23 Jan 2022 21:34:34 +0100 Subject: [PATCH 2/3] Change wording of the hint This is to avoid the wrong idea that flex-wrap without defined space of items it affects is working "incorrectly". --- flex/07-flex-layout-2/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/flex/07-flex-layout-2/README.md b/flex/07-flex-layout-2/README.md index 3c7316b..df82525 100644 --- a/flex/07-flex-layout-2/README.md +++ b/flex/07-flex-layout-2/README.md @@ -8,7 +8,7 @@ As with the previous exercise, we've left a little more for you to do. - You will need to change the flex-direction to push the footer down. - You will need to add some divs as containers to get things to line up correctly. - `flex-wrap` will help get the cards aligned correctly. -- Make sure cards know how much space they should take for `flex-wrap` to work correctly. +- Make sure cards know how much space they should take for `flex-wrap` to work as intended. ## Desired outcome From 16379dbfbcbffe5f58c9e00dc6196b8387cab935 Mon Sep 17 00:00:00 2001 From: scheals <95084627+scheals@users.noreply.github.com> Date: Mon, 24 Jan 2022 12:08:23 +0100 Subject: [PATCH 3/3] Refine wording of the hint Remove a step of abstraction about cards "knowing" so the hint directly references defining space of cards. Co-authored-by: Eric Olkowski <70952936+thatblindgeye@users.noreply.github.com> --- flex/07-flex-layout-2/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/flex/07-flex-layout-2/README.md b/flex/07-flex-layout-2/README.md index df82525..30a8346 100644 --- a/flex/07-flex-layout-2/README.md +++ b/flex/07-flex-layout-2/README.md @@ -8,7 +8,7 @@ As with the previous exercise, we've left a little more for you to do. - You will need to change the flex-direction to push the footer down. - You will need to add some divs as containers to get things to line up correctly. - `flex-wrap` will help get the cards aligned correctly. -- Make sure cards know how much space they should take for `flex-wrap` to work as intended. +- Make sure you define how much space the cards should take up, in order for `flex-wrap` to work as intended. ## Desired outcome