From 1965908802a3608582d1759fe9a17816e9a6b2ec Mon Sep 17 00:00:00 2001 From: Manuel Date: Mon, 31 Jan 2022 00:11:22 -0300 Subject: [PATCH 1/2] Modify Self Check item on README.md --- grid/01-grid-layout-1/README.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/grid/01-grid-layout-1/README.md b/grid/01-grid-layout-1/README.md index 1793fce..e3a3ecf 100644 --- a/grid/01-grid-layout-1/README.md +++ b/grid/01-grid-layout-1/README.md @@ -3,6 +3,7 @@ Now it's time to practice the Grid tools we've learned and create a layout that might seem familiar. We're going to make a Holy Grail Layout like the ones we created using Flexbox. The difference here is that we won't be relying on Flexbox for this exercise. We'll only be using Grid. You'll be able to see the benefits of Grid for yourself! ### Hints + - You only need to add to the CSS selectors - Look back to the Creating a Grid lesson if you forget how to turn an element into a grid - Use fixed track sizes (e.g. pixels) for your columns and rows @@ -12,10 +13,11 @@ Now it's time to practice the Grid tools we've learned and create a layout that ![desired outcome](./desired-outcome.png) ### Self Check + - The gap is 15px - The grid has two columns - The grid has four rows -- The first column is three times larger than the other +- The second column is three times larger than the first - The third row is five times larger than the others - The header and footer elements span across both columns - The sidebar element only spans across the first column From 0dc37ecae6f914ef61a17ec85c2700db3a0a3d08 Mon Sep 17 00:00:00 2001 From: Eric Olkowski <70952936+thatblindgeye@users.noreply.github.com> Date: Mon, 31 Jan 2022 20:16:25 -0500 Subject: [PATCH 2/2] Update PULL_REQUEST_TEMPLATE.md --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 8edabc4..a10b872 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -2,7 +2,7 @@ - [ ] I have thoroughly read and understand the [CSS Exercises Contributing Guide](https://github.com/TheOdinProject/css-exercises/blob/main/CONTRIBUTING.md) -- [ ] The title of this PR is in `file/exercise/folder: brief description of changes` format e.g. `01 flex center: add hint for XYZ` +- [ ] The title of this PR is similar to the `file, exercise/lesson, or folder: brief description of changes` format e.g. `01 flex center: add hint for XYZ` - [ ] If one exists, I have linked a related open issue to this PR in Step 2 below