tod
/
odin-default-js-exercises
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
odin-default-js-exercises/.github/PULL_REQUEST_TEMPLATE.md

33 lines
1.8 KiB
Markdown
Raw Normal View History

PR Template: Flip order of checklist and details (#289) * PR Template: Flip order of checklist and details Because: If the details are first, they are viewable in Discord's webhook. This PR: * Moves the detail sections to the beginning of the template * Moves the checklist section to the end of the template * Adds an issue section to link the issue * Adds the Because, This PR, and Issue sections to checklist * Reduce wording that is not essential
2022-10-22 02:43:16 +00:00
<!-- Thank you for taking the time to contribute to The Odin Project. In order to get this pull request (PR) merged in a reasonable amount of time, you must complete this entire template. -->
Create PULL_REQUEST_TEMPLATE.md
2022-02-14 20:07:50 +00:00
PR Template: Flip order of checklist and details (#289) * PR Template: Flip order of checklist and details Because: If the details are first, they are viewable in Discord's webhook. This PR: * Moves the detail sections to the beginning of the template * Moves the checklist section to the end of the template * Adds an issue section to link the issue * Adds the Because, This PR, and Issue sections to checklist * Reduce wording that is not essential
2022-10-22 02:43:16 +00:00
## Because
<!-- Summarize the purpose or reasons for this PR, e.g. what problem it solves or what benefit it provides. -->
Create PULL_REQUEST_TEMPLATE.md
2022-02-14 20:07:50 +00:00
PR Template: Flip order of checklist and details (#289) * PR Template: Flip order of checklist and details Because: If the details are first, they are viewable in Discord's webhook. This PR: * Moves the detail sections to the beginning of the template * Moves the checklist section to the end of the template * Adds an issue section to link the issue * Adds the Because, This PR, and Issue sections to checklist * Reduce wording that is not essential
2022-10-22 02:43:16 +00:00
## This PR
<!-- A bullet point list of one or more items describing the specific changes. -->
Create PULL_REQUEST_TEMPLATE.md
2022-02-14 20:07:50 +00:00
PR Template: Flip order of checklist and details (#289) * PR Template: Flip order of checklist and details Because: If the details are first, they are viewable in Discord's webhook. This PR: * Moves the detail sections to the beginning of the template * Moves the checklist section to the end of the template * Adds an issue section to link the issue * Adds the Because, This PR, and Issue sections to checklist * Reduce wording that is not essential
2022-10-22 02:43:16 +00:00
## Issue
<!--
If this PR closes an open issue in this repo, replace the XXXXX below with the issue number, e.g. Closes #2013.
Update PULL_REQUEST_TEMPLATE.md
2022-02-20 18:25:26 +00:00
PR Template: Flip order of checklist and details (#289) * PR Template: Flip order of checklist and details Because: If the details are first, they are viewable in Discord's webhook. This PR: * Moves the detail sections to the beginning of the template * Moves the checklist section to the end of the template * Adds an issue section to link the issue * Adds the Because, This PR, and Issue sections to checklist * Reduce wording that is not essential
2022-10-22 02:43:16 +00:00
If this PR closes an open issue in another TOP repo, replace the #XXXXX with the URL of the issue, e.g. Closes https://github.com/TheOdinProject/curriculum/issues/XXXXX
Update PULL_REQUEST_TEMPLATE.md
2022-02-20 18:25:26 +00:00
PR Template: Flip order of checklist and details (#289) * PR Template: Flip order of checklist and details Because: If the details are first, they are viewable in Discord's webhook. This PR: * Moves the detail sections to the beginning of the template * Moves the checklist section to the end of the template * Adds an issue section to link the issue * Adds the Because, This PR, and Issue sections to checklist * Reduce wording that is not essential
2022-10-22 02:43:16 +00:00
If this PR does not close, but is related to another issue or PR, you can link it as above without the 'Closes' keyword, e.g. 'Related to #2013'.
-->
Closes #XXXXX
Update PULL_REQUEST_TEMPLATE.md
2022-02-20 18:25:26 +00:00
PR Template: Flip order of checklist and details (#289) * PR Template: Flip order of checklist and details Because: If the details are first, they are viewable in Discord's webhook. This PR: * Moves the detail sections to the beginning of the template * Moves the checklist section to the end of the template * Adds an issue section to link the issue * Adds the Because, This PR, and Issue sections to checklist * Reduce wording that is not essential
2022-10-22 02:43:16 +00:00
## Additional Information
<!-- Any other information about this PR, such as a link to a Discord discussion. -->
Update PULL_REQUEST_TEMPLATE.md
2022-02-20 18:25:26 +00:00
PR Template: Flip order of checklist and details (#289) * PR Template: Flip order of checklist and details Because: If the details are first, they are viewable in Discord's webhook. This PR: * Moves the detail sections to the beginning of the template * Moves the checklist section to the end of the template * Adds an issue section to link the issue * Adds the Because, This PR, and Issue sections to checklist * Reduce wording that is not essential
2022-10-22 02:43:16 +00:00
## Pull Request Requirements
<!-- Replace the whitespace between the square brackets with an 'x', e.g. [x]. After you create the PR, they will become checkboxes that you can click on. -->
CONTRIBUTING.md: repoint contributing links to .github/CONTRIBUTING.md (#371) * repoint contributing links to .github/CONTRIBUTING.md * drop mention of which repo it is
2023-07-05 12:41:21 +00:00
- [ ] I have thoroughly read and understand [The Odin Project Contributing Guide](https://github.com/TheOdinProject/.github/blob/main/CONTRIBUTING.md)
PR Template: Flip order of checklist and details (#289) * PR Template: Flip order of checklist and details Because: If the details are first, they are viewable in Discord's webhook. This PR: * Moves the detail sections to the beginning of the template * Moves the checklist section to the end of the template * Adds an issue section to link the issue * Adds the Because, This PR, and Issue sections to checklist * Reduce wording that is not essential
2022-10-22 02:43:16 +00:00
- [ ] The title of this PR follows the `location of change: brief description of change` format, e.g. `01_helloWorld: Update test cases`
- [ ] The `Because` section summarizes the reason for this PR
- [ ] The `This PR` section has a bullet point list describing the changes in this PR
- [ ] If this PR addresses an open issue, it is linked in the `Issue` section
Fix: change requirement to reflect solutions change
2023-07-05 11:50:13 +00:00
- [ ] If this PR includes any changes that affect the solution of an exercise, I've also updated the solution in the `/solutions` folder