From 1aa228d42cb90f8e9182bc849447f7473da42d03 Mon Sep 17 00:00:00 2001 From: Mohammed Nabeel Date: Wed, 15 Jul 2020 18:26:03 +0300 Subject: [PATCH] Ignores non-present values --- removeFromArray/removeFromArray.js | 4 +++- removeFromArray/removeFromArray.spec.js | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/removeFromArray/removeFromArray.js b/removeFromArray/removeFromArray.js index d69f9e1..6d882c0 100644 --- a/removeFromArray/removeFromArray.js +++ b/removeFromArray/removeFromArray.js @@ -7,7 +7,9 @@ const removeFromArray = function(...args) { // Remove all the remaining elements from the array for (let i = 1; i < args.length; i++) { pos = myArray.indexOf(args[i]); - myArray.splice(pos, 1); + if (pos >= 0) { //Is it a valid argument + myArray.splice(pos, 1); + } } return myArray; diff --git a/removeFromArray/removeFromArray.spec.js b/removeFromArray/removeFromArray.spec.js index 60903a8..a1f499e 100644 --- a/removeFromArray/removeFromArray.spec.js +++ b/removeFromArray/removeFromArray.spec.js @@ -7,7 +7,7 @@ describe('removeFromArray', function() { it('removes multiple values', function() { expect(removeFromArray([1, 2, 3, 4], 3, 2)).toEqual([1, 4]); }); - xit('ignores non present values', function() { + it('ignores non present values', function() { expect(removeFromArray([1, 2, 3, 4], 7, "tacos")).toEqual([1, 2, 3, 4]); }); xit('ignores non present values, but still works', function() {