tod
/
odin-default-js-exercises
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Tidy up of code

This commit is contained in:
billalp 2019-11-01 12:42:40 +00:00
parent c7d61f82e9
commit 27afb52393
2 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
palindromes/palindromes.js
View File

@ -1,5 +1,5 @@
const palindromes = function(word) { const palindromes = function(word) {
const wordArr = word.split(''); const wordArr = word.replace().toLowerCase().split('');
const reversedArray = wordArr.reverse(); const reversedArray = wordArr.reverse();
newArray = []; newArray = [];
@ -8,7 +8,7 @@ const palindromes = function(word) {
if (wordArr[i] === reversedArray[i]) { if (wordArr[i] === reversedArray[i]) {
newArray.push(wordArr[i]) newArray.push(wordArr[i])
} else { } else {
newArray = ['Not a palindrome']; break;
} }
} }
return true ? newArray.join('') === word : false; return true ? newArray.join('') === word : false;

13
palindromes/palindromes.spec.js
View File

@ -4,17 +4,20 @@ describe('palindromes', function() {
it('works with single words', function() { it('works with single words', function() {
expect(palindromes('racecar')).toEqual(true); expect(palindromes('racecar')).toEqual(true);
}); });
xit('works with punctuation', function() {
it('works with punctuation', function() {
expect(palindromes('Racecar!')).toEqual(true); expect(palindromes('Racecar!')).toEqual(true);
}); });
xit('works with multiple words', function() {
it('works with multiple words', function() {
expect(palindromes('A car, a man, a maraca.')).toEqual(true); expect(palindromes('A car, a man, a maraca.')).toEqual(true);
}); });
xit('works with multiple words', function() {
it('works with lots of words', function() {
expect(palindromes('Animal loots foliated detail of stool lamina.')).toEqual(true); expect(palindromes('Animal loots foliated detail of stool lamina.')).toEqual(true);
}); });
xit('doesn\'t just always return true', function() {
it('doesn\'t just always return true', function() {
expect(palindromes('ZZZZ car, a man, a maraca.')).toEqual(false); expect(palindromes('ZZZZ car, a man, a maraca.')).toEqual(false);
}); });
}); });