diff --git a/sumAll/sumAll.js b/sumAll/sumAll.js index 4030fe8..115065c 100644 --- a/sumAll/sumAll.js +++ b/sumAll/sumAll.js @@ -1,5 +1,21 @@ -const sumAll = function() { +const sumAll = function(min, max) { + let temporal; + let message = "ERROR"; + let sum = 0; + if(min < 0 || max < 0){ + return message; + }else if(typeof min !== "number" || typeof max !== "number"){ + return message; + }if(max < min ){ + temporal = max; + max = min; + min = temporal; + } -} + for (let index = min; index < max + 1; index++) { + sum += index; + } + return sum; +}; module.exports = sumAll diff --git a/sumAll/sumAll.spec.js b/sumAll/sumAll.spec.js index 520adc1..2a584a6 100644 --- a/sumAll/sumAll.spec.js +++ b/sumAll/sumAll.spec.js @@ -4,19 +4,19 @@ describe('sumAll', function() { it('sums numbers within the range', function() { expect(sumAll(1, 4)).toEqual(10); }); - xit('works with large numbers', function() { + it('works with large numbers', function() { expect(sumAll(1, 4000)).toEqual(8002000); }); - xit('works with larger number first', function() { + it('works with larger number first', function() { expect(sumAll(123, 1)).toEqual(7626); }); - xit('returns ERROR with negative numbers', function() { + it('returns ERROR with negative numbers', function() { expect(sumAll(-10, 4)).toEqual('ERROR'); }); - xit('returns ERROR with non-number parameters', function() { + it('returns ERROR with non-number parameters', function() { expect(sumAll(10, "90")).toEqual('ERROR'); }); - xit('returns ERROR with non-number parameters', function() { + it('returns ERROR with non-number parameters', function() { expect(sumAll(10, [90, 1])).toEqual('ERROR'); }); });