diff --git a/sumAll/sumAll.js b/sumAll/sumAll.js index 4030fe8..af48119 100644 --- a/sumAll/sumAll.js +++ b/sumAll/sumAll.js @@ -1,5 +1,20 @@ -const sumAll = function() { +const sumAll = function (a, b) { + if (!Number.isInteger(a) || !Number.isInteger(b)) + return 'ERROR'; + if (a < 0 || b < 0) + return 'ERROR'; + + if (a > b) { + let temp = b; + b = a; + a = temp; + } + let ans = 0; + for (let i = a; i <= b; i++) + ans += i; + + return ans; } module.exports = sumAll diff --git a/sumAll/sumAll.spec.js b/sumAll/sumAll.spec.js index 520adc1..2a584a6 100644 --- a/sumAll/sumAll.spec.js +++ b/sumAll/sumAll.spec.js @@ -4,19 +4,19 @@ describe('sumAll', function() { it('sums numbers within the range', function() { expect(sumAll(1, 4)).toEqual(10); }); - xit('works with large numbers', function() { + it('works with large numbers', function() { expect(sumAll(1, 4000)).toEqual(8002000); }); - xit('works with larger number first', function() { + it('works with larger number first', function() { expect(sumAll(123, 1)).toEqual(7626); }); - xit('returns ERROR with negative numbers', function() { + it('returns ERROR with negative numbers', function() { expect(sumAll(-10, 4)).toEqual('ERROR'); }); - xit('returns ERROR with non-number parameters', function() { + it('returns ERROR with non-number parameters', function() { expect(sumAll(10, "90")).toEqual('ERROR'); }); - xit('returns ERROR with non-number parameters', function() { + it('returns ERROR with non-number parameters', function() { expect(sumAll(10, [90, 1])).toEqual('ERROR'); }); });