Change function arguments in removeFromArray

As per current definition,
within the forEach loop, the array itself (being an element of args)
is checked for includes('item'), leading to one additional comparison.

However, it doesn't lead to error as item will never be the array itself.
By splitting the arguments here, the additional comparison is avoided.
This commit is contained in:
Rajas Shah 2022-09-28 17:48:32 -06:00
parent db998d7279
commit 4a267cd05a
1 changed files with 2 additions and 2 deletions

View File

@ -1,9 +1,9 @@
// we have 2 solutions here, an easier one and a more advanced one.
// The easiest way to get an array of all of the arguments that are passed to a function
// is using the rest operator. If this is unfamiliar to you look it up!
const removeFromArray = function (...args) {
const removeFromArray = function (array, ...args) {
// the very first item in our list of arguments is the array, we pull it out with args[0]
const array = args[0];
// const array = args[0];
// create a new empty array
const newArray = [];
// use forEach to go through the array