tod
/
odin-default-js-exercises
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #17 from BillalPatel/remove-from-array 

Working now
This commit is contained in:
Billal Patel 2019-11-17 17:16:05 +00:00 committed by GitHub
parent b27adb1097 54f475e0b6
commit 6e2cdb8a63
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
removeFromArray/removeFromArray.js
View File

@ -1,16 +1,14 @@
const removeFromArray = function(arr, ...args) { const removeFromArray = function(arr, ...args) {
const filteredArray = []; const filteredArray = arr;
// const array = args;
const array = [3];
for (let i = 0; i < array.length; i++) { for (let i = 0; i < args.length; i++) {
if (arr.includes(array[i])) { if (arr.includes(args[i])) {
// filteredArray.push(5); let index = arr.indexOf(args[i]);
} else if (arr.includes(array[0])) { filteredArray.splice(index, 1);
// continue; } else if (arr.includes(args[i])) {
continue;
} }
} }
return filteredArray; return filteredArray;
} }

10
removeFromArray/removeFromArray.spec.js
View File

@ -4,19 +4,19 @@ describe('removeFromArray', function() {
it('removes a single value', function() { it('removes a single value', function() {
expect(removeFromArray([1, 2, 3, 4], 3)).toEqual([1, 2, 4]); expect(removeFromArray([1, 2, 3, 4], 3)).toEqual([1, 2, 4]);
}); });
xit('removes multiple values', function() { it('removes multiple values', function() {
expect(removeFromArray([1, 2, 3, 4], 3, 2)).toEqual([1, 4]); expect(removeFromArray([1, 2, 3, 4], 3, 2)).toEqual([1, 4]);
}); });
xit('ignores non present values', function() { it('ignores non present values', function() {
expect(removeFromArray([1, 2, 3, 4], 7, "tacos")).toEqual([1, 2, 3, 4]); expect(removeFromArray([1, 2, 3, 4], 7, "tacos")).toEqual([1, 2, 3, 4]);
}); });
xit('ignores non present values, but still works', function() { it('ignores non present values, but still works', function() {
expect(removeFromArray([1, 2, 3, 4], 7, 2)).toEqual([1, 3, 4]); expect(removeFromArray([1, 2, 3, 4], 7, 2)).toEqual([1, 3, 4]);
}); });
xit('can remove all values', function() { it('can remove all values', function() {
expect(removeFromArray([1, 2, 3, 4], 1, 2, 3, 4)).toEqual([]); expect(removeFromArray([1, 2, 3, 4], 1, 2, 3, 4)).toEqual([]);
}); });
xit('works with strings', function() { it('works with strings', function() {
expect(removeFromArray(["hey", 2, 3, "ho"], "hey", 3)).toEqual([2, "ho"]); expect(removeFromArray(["hey", 2, 3, "ho"], "hey", 3)).toEqual([2, "ho"]);
}); });
}); });