From 7beb49e5936804d78970f209683ebd2671e7fdc0 Mon Sep 17 00:00:00 2001
From: c-auri <43008483+c-auri@users.noreply.github.com>
Date: Fri, 18 Nov 2022 16:17:40 +0100
Subject: [PATCH] Inline codeSet and use const variable instead

1) codeSet is not a good function name, since it includes no verb
2) extracting a const variable makes the function call redudant
   and shortens line 24 to be less than 80 characters wide
---
 caesar/caesar.js | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/caesar/caesar.js b/caesar/caesar.js
index 9401590..5839278 100644
--- a/caesar/caesar.js
+++ b/caesar/caesar.js
@@ -5,8 +5,6 @@ const caesar = function(string, shiftValue) {
     .join("");
 };
 
-const codeSet = code => (code < 97 ? 65 : 97);
-
 // This function implements a version of the modulo operator
 // that returns the smallest positive remainder even for negative inputs.
 // See this link for details:
@@ -17,7 +15,8 @@ const shift = (char, shiftValue) => {
   const code = char.charCodeAt();
 
   if ((code >= 65 && code <= 90) || (code >= 97 && code <= 122)) {
-    const shiftedCode = mod(code + shiftValue - codeSet(code), 26) + codeSet(code);
+    const base = code < 97 ? 65 : 97;
+    const shiftedCode = mod(code + shiftValue - base, 26) + base;
     return String.fromCharCode(shiftedCode);
   }
   return char;