From a05d4d60c8376df82edb50da462cdc36df9fa31a Mon Sep 17 00:00:00 2001 From: Rachel Moser <33227096+rlmoser99@users.noreply.github.com> Date: Fri, 21 Oct 2022 21:43:16 -0500 Subject: [PATCH] PR Template: Flip order of checklist and details (#289) * PR Template: Flip order of checklist and details Because: If the details are first, they are viewable in Discord's webhook. This PR: * Moves the detail sections to the beginning of the template * Moves the checklist section to the end of the template * Adds an issue section to link the issue * Adds the Because, This PR, and Issue sections to checklist * Reduce wording that is not essential --- .github/PULL_REQUEST_TEMPLATE.md | 42 +++++++++++++++++--------------- 1 file changed, 22 insertions(+), 20 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 5a8d2e0..d3ee065 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,30 +1,32 @@ - + -Complete the following REQUIRED checkboxes: - -- [ ] I have thoroughly read and understand [The Odin Project Contributing Guide](https://github.com/TheOdinProject/theodinproject/blob/main/CONTRIBUTING.md) -- [ ] The title of this PR follows the `location of change: brief description of change` format, e.g. `01_helloWorld: Update test cases` +## Because + -Complete the following checkboxes ONLY IF they are applicable to your PR. You can complete them later if they are not currently applicable: -- [ ] I have ensured any exercise files included in this PR have passed all of their tests -
+## This PR + -**1. Because:** + +## Issue +If this PR closes an open issue in another TOP repo, replace the #XXXXX with the URL of the issue, e.g. Closes https://github.com/TheOdinProject/curriculum/issues/XXXXX + +If this PR does not close, but is related to another issue or PR, you can link it as above without the 'Closes' keyword, e.g. 'Related to #2013'. +--> Closes #XXXXX - -**2. This PR:** - +## Additional Information + -**3. Additional Information:** - - +## Pull Request Requirements + +- [ ] I have thoroughly read and understand [The Odin Project Contributing Guide](https://github.com/TheOdinProject/theodinproject/blob/main/CONTRIBUTING.md) +- [ ] The title of this PR follows the `location of change: brief description of change` format, e.g. `01_helloWorld: Update test cases` +- [ ] The `Because` section summarizes the reason for this PR +- [ ] The `This PR` section has a bullet point list describing the changes in this PR +- [ ] If this PR addresses an open issue, it is linked in the `Issue` section +- [ ] If this PR includes changes that needs to be updated on the `solutions` branch, I have created another PR (and linked it to this PR).