diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md new file mode 100644 index 0000000..4c4571c --- /dev/null +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -0,0 +1,54 @@ +--- +name: Bug Report +about: Create a report to help us improve something that is not working correctly +title: "Bug - :" +labels: "Status: Needs Review, Type: Bug" +assignees: "" +--- + + + +Complete the following REQUIRED checkboxes: +- [ ] I have thoroughly read and understand [The Odin Project Contributing Guide](https://github.com/TheOdinProject/theodinproject/blob/main/CONTRIBUTING.md) +- [ ] The title of this issue follows the `Bug - location of bug: brief description of bug` format, e.g. `Bug - Exercises: File type incorrect for all test files` + +The following checkbox is OPTIONAL: + +- [ ] I would like to be assigned this issue to work on it + +
+ +**1. Description of the Bug:** + + + +**2. How To Reproduce:** + + + +**3. Expected Behavior:** + + + +**4. Desktop/Device:** + +- Device: +- OS: +- Browser: +- Version: + +**5. Additional Information:** + + diff --git a/.github/ISSUE_TEMPLATE/feature_request.md b/.github/ISSUE_TEMPLATE/feature_request.md new file mode 100644 index 0000000..4814cc2 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/feature_request.md @@ -0,0 +1,38 @@ +--- +name: Feature Request +about: Suggest a new feature or enhancement for this project +title: "" +labels: "Status: Needs Review" +assignees: "" +--- + + + +Complete the following REQUIRED checkboxes: +- [ ] I have thoroughly read and understand [The Odin Project Contributing Guide](https://github.com/TheOdinProject/theodinproject/blob/main/CONTRIBUTING.md) +- [ ] The title of this issue follows the `location for request: brief description of request` format, e.g. `Exercises: Add exercise on XYZ` + +The following checkbox is OPTIONAL: + +- [ ] I would like to be assigned this issue to work on it + +
+ +**1. Description of the Feature Request:** + + + +**2. Acceptance Criteria:** + + + +**3. Additional Information:** + + diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 0000000..d3ee065 --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,32 @@ + + +## Because + + + +## This PR + + + +## Issue + +Closes #XXXXX + +## Additional Information + + + +## Pull Request Requirements + +- [ ] I have thoroughly read and understand [The Odin Project Contributing Guide](https://github.com/TheOdinProject/theodinproject/blob/main/CONTRIBUTING.md) +- [ ] The title of this PR follows the `location of change: brief description of change` format, e.g. `01_helloWorld: Update test cases` +- [ ] The `Because` section summarizes the reason for this PR +- [ ] The `This PR` section has a bullet point list describing the changes in this PR +- [ ] If this PR addresses an open issue, it is linked in the `Issue` section +- [ ] If this PR includes changes that needs to be updated on the `solutions` branch, I have created another PR (and linked it to this PR). diff --git a/07_tempConversion/README.md b/07_tempConversion/README.md index 081a650..77682f6 100644 --- a/07_tempConversion/README.md +++ b/07_tempConversion/README.md @@ -2,12 +2,12 @@ Write two functions that convert temperatures from Fahrenheit to Celsius, and vice versa: ``` -ftoc(32) // fahrenheit to celsius, should return 0 +convertToCelsius(32) // fahrenheit to celsius, should return 0 -ctof(0) // celsius to fahrenheit, should return 32 +convertToFahrenheit(0) // celsius to fahrenheit, should return 32 ``` -Because we are human, we want the result temperature to be rounded to one decimal place: i.e., `ftoc(100)` should return `37.8` and not `37.77777777777778`. +Because we are human, we want the result temperature to be rounded to one decimal place: i.e., `convertToCelsius(100)` should return `37.8` and not `37.77777777777778`. This exercise asks you to create more than one function so the `module.exports` section of the spec file looks a little different this time. Nothing to worry about, we're just packaging both functions into a single object to be exported. diff --git a/07_tempConversion/tempConversion.js b/07_tempConversion/tempConversion.js index 6ef3e85..14153e0 100644 --- a/07_tempConversion/tempConversion.js +++ b/07_tempConversion/tempConversion.js @@ -1,13 +1,11 @@ -const ftoc = function() { - +const convertToCelsius = function() { }; -const ctof = function() { - +const convertToFahrenheit = function() { }; // Do not edit below this line module.exports = { - ftoc, - ctof + convertToCelsius, + convertToFahrenheit }; diff --git a/07_tempConversion/tempConversion.spec.js b/07_tempConversion/tempConversion.spec.js index 93679cc..c4f9742 100644 --- a/07_tempConversion/tempConversion.spec.js +++ b/07_tempConversion/tempConversion.spec.js @@ -1,25 +1,25 @@ -const {ftoc, ctof} = require('./tempConversion') +const {convertToCelsius, convertToFahrenheit} = require('./tempConversion') -describe('ftoc', () => { +describe('convertToCelsius', () => { test('works', () => { - expect(ftoc(32)).toEqual(0); + expect(convertToCelsius(32)).toEqual(0); }); test.skip('rounds to 1 decimal', () => { - expect(ftoc(100)).toEqual(37.8); + expect(convertToCelsius(100)).toEqual(37.8); }); test.skip('works with negatives', () => { - expect(ftoc(-100)).toEqual(-73.3); + expect(convertToCelsius(-100)).toEqual(-73.3); }); }); -describe('ctof', () => { +describe('convertToFahrenheit', () => { test.skip('works', () => { - expect(ctof(0)).toEqual(32); + expect(convertToFahrenheit(0)).toEqual(32); }); test.skip('rounds to 1 decimal', () => { - expect(ctof(73.2)).toEqual(163.8); + expect(convertToFahrenheit(73.2)).toEqual(163.8); }); test.skip('works with negatives', () => { - expect(ctof(-10)).toEqual(14); + expect(convertToFahrenheit(-10)).toEqual(14); }); });