tod
/
odin-default-js-exercises
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #5 from BillalPatel/palindrome 

Tidy up of code
This commit is contained in:
Billal Patel 2019-11-01 14:17:28 +00:00 committed by GitHub
parent 68eebc9015 07ced0fc05
commit adbdfeffe9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
palindromes/palindromes.js
View File

@ -1,5 +1,5 @@
const palindromes = function(word) {
const wordArr = word.split('');
const wordArr = word.replace(/\W/g, '').toLowerCase().split('');
const reversedArray = wordArr.reverse();
newArray = [];
@ -8,10 +8,10 @@ const palindromes = function(word) {
if (wordArr[i] === reversedArray[i]) {
newArray.push(wordArr[i])
} else {
newArray = ['Not a palindrome'];
break;
}
}
return true ? newArray.join('') === word : false;
return true ? newArray.join('') === word.replace(/\W/g, '').toLowerCase() : false;
}
module.exports = palindromes

13
palindromes/palindromes.spec.js
View File

@ -4,17 +4,20 @@ describe('palindromes', function() {
it('works with single words', function() {
expect(palindromes('racecar')).toEqual(true);
});
xit('works with punctuation', function() {
it('works with punctuation', function() {
expect(palindromes('Racecar!')).toEqual(true);
});
xit('works with multiple words', function() {
it('works with multiple words', function() {
expect(palindromes('A car, a man, a maraca.')).toEqual(true);
});
xit('works with multiple words', function() {
it('works with lots of words', function() {
expect(palindromes('Animal loots foliated detail of stool lamina.')).toEqual(true);
});
xit('doesn\'t just always return true', function() {
it('doesn\'t just always return true', function() {
expect(palindromes('ZZZZ car, a man, a maraca.')).toEqual(false);
});
});