From b151f4e87f5af8feb79ececd9caa5ddfabe4ae55 Mon Sep 17 00:00:00 2001
From: abduldoesramen <abdulrehman821337@gmail.com>
Date: Fri, 23 Jun 2023 15:29:53 +1000
Subject: [PATCH] tests :white_check_mark: pass sumAll

---
 05_sumAll/sumAll.js      | 18 +++++++++++++++++-
 05_sumAll/sumAll.spec.js | 10 +++++-----
 2 files changed, 22 insertions(+), 6 deletions(-)

diff --git a/05_sumAll/sumAll.js b/05_sumAll/sumAll.js
index 00880c7..a3cf974 100644
--- a/05_sumAll/sumAll.js
+++ b/05_sumAll/sumAll.js
@@ -1,5 +1,21 @@
-const sumAll = function() {
+const sumAll = function (numOne, numTwo) {
+    
+    /* Checks */
+    if (typeof numOne !== "number" || numOne < 0 || typeof numTwo !== "number" || numTwo < 0) {
+        return "ERROR";
+    }
 
+    if (numOne > numTwo) {
+        var placeHold = numTwo
+        numTwo = numOne;
+        numOne = placeHold; 
+    }
+
+    var sum = 0;
+    for (i = numOne; i <= numTwo; i++) {
+        sum += i;
+    }
+    return sum;
 };
 
 // Do not edit below this line
diff --git a/05_sumAll/sumAll.spec.js b/05_sumAll/sumAll.spec.js
index 1a9fb7c..a171e5f 100644
--- a/05_sumAll/sumAll.spec.js
+++ b/05_sumAll/sumAll.spec.js
@@ -4,19 +4,19 @@ describe('sumAll', () => {
   test('sums numbers within the range', () => {
     expect(sumAll(1, 4)).toEqual(10);
   });
-  test.skip('works with large numbers', () => {
+  test('works with large numbers', () => {
     expect(sumAll(1, 4000)).toEqual(8002000);
   });
-  test.skip('works with larger number first', () => {
+  test('works with larger number first', () => {
     expect(sumAll(123, 1)).toEqual(7626);
   });
-  test.skip('returns ERROR with negative numbers', () => {
+  test('returns ERROR with negative numbers', () => {
     expect(sumAll(-10, 4)).toEqual('ERROR');
   });
-  test.skip('returns ERROR with non-number parameters', () => {
+  test('returns ERROR with non-number parameters', () => {
     expect(sumAll(10, "90")).toEqual('ERROR');
   });
-  test.skip('returns ERROR with non-number parameters', () => {
+  test('returns ERROR with non-number parameters', () => {
     expect(sumAll(10, [90, 1])).toEqual('ERROR');
   });
 });