The test for the 'multiply' function used array brackets [] for the input parameters, which caused the test to return an error when rest parameters (...args) are used in the function, like so:
const multiply = function(...args){
return args.reduce((acc, cur) => acc * cur);
}
The previous solution removed numbers entirely, whereas this one treats
them like letters and checks if they are evenly spaced.
More importantly, the old solution test seemed to check if the numbers
were palindromic, but because the solution replaced them with "", it
wasn't testing what it seemed to.
I added a new test to differentiate between the palindromic "rac3e3car"
and the non-palindromic "r3ace3car".
These changes also obviate the problems raised in Issue #355.
The previous solution removed numbers entirely, whereas this one treats
them like letters and checks if they are evenly spaced.
More importantly, the old solution test seemed to check if the numbers
were palindromic, but because the solution replaced them with "", it
wasn't testing what it seemed to.
I added a new test to differentiate between the palindromic "rac3e3car"
and the non-palindromic "r3ace3car".
Previous Fibonacci solution didn't use arrays, and since this is an
array-heavy section, it seemed better to have that be the method here.
Also, it accounts for entering 0 as an argument without having to add
any extra code, which takes care of some currently open issues.
Issues #192 and #236 are about the same thing.
I added a test for that as well.
* PR Template: Flip order of checklist and details
Because:
If the details are first, they are viewable in Discord's webhook.
This PR:
* Moves the detail sections to the beginning of the template
* Moves the checklist section to the end of the template
* Adds an issue section to link the issue
* Adds the Because, This PR, and Issue sections to checklist
* Reduce wording that is not essential
fruddenfeldt
MarLatte
Eric Olkowski
thatblindgeye
Ryan McEntire
Kevin Mulhern
Alex-Nemet
Asartea
jhylacey
01zulfi
Telcean Marius-Andrei
Rachel Moser
Jeremy Myers
Michael Frank