Marvin Gay
4e004bdb1f
Merge pull request #76 from kyriri/patch-1
...
Further clarify guidelines
2020-09-13 21:14:20 -04:00
Musabii
f9a972ec16
changed the order of if conditions
...
it flows better logically to first check if the inputs are a number than to check if they are negative.
2020-06-25 11:58:02 +02:00
Musabii
4d82ea16db
added a test and changed an old one
...
The second test would originally test if it works with upper-case letters and punctuation. but the description of the test is "works with punctuation". I think it is better to either put both in the description or make a new test that solely tests each different thing.
2020-06-25 11:17:48 +02:00
kyriri
da45b701d4
Further clarify guidelines
...
Everybody in the Southern hemisphere experiences winter in July and that's normal, so the original remark added an unnecessary (and off-topic) layer of confusion.
2020-05-13 20:17:22 -03:00
Briggs Elsperger
888383a44e
Merge pull request #74 from imrogerjiang/new-tests
2020-05-09 12:16:42 -05:00
Roger
5817ea2140
Added blank string test to repeatString
2020-05-08 16:59:37 +10:00
Roger
3758497cb2
Added blank string test to reverseString
2020-05-08 16:56:55 +10:00
Roger
68691ab7a6
Added same type test to removeFromArray
2020-05-08 16:54:31 +10:00
Briggs Elsperger
c0d736a524
Merge pull request #73 from Timework/patch-1
2020-05-02 21:29:46 -05:00
Christopher Martinez
fb5677ee8f
Changed let to const and added some comments.
...
I changed the let to a const and added some explanation to how the test is conducted in comments included in the test.
2020-05-02 09:04:40 -05:00
Christopher Martinez
312103dc4f
Added random test
...
I added a random test getting a number from 1 to 1000. You said you wanted comments on it but I was not sure where to put them. I added the global modifier to the recommended regex in order for it count all the words properly.
2020-05-01 12:44:55 -05:00
Briggs Elsperger
26d610ca6e
Update README.md
2020-04-21 14:51:23 -06:00
Briggs Elsperger
9e2e2995e7
Update README.md
2020-04-21 14:51:06 -06:00
Cody Loyd
c61615f4bf
Merge pull request #64 from santimc/patch-1
...
Delete .DS_Store
2020-02-12 12:58:00 -06:00
Cody Loyd
3b51e5dbef
Update fibonacci.js
2020-01-29 10:52:57 -06:00
santimc
ecc0872e96
Delete .DS_Store
2020-01-09 17:08:41 -03:00
Cody Loyd
f228d73f98
Merge pull request #45 from nearmint/patch-1
...
Fix typo
2019-11-27 09:18:56 -06:00
Cody Loyd
1d854ec580
Merge pull request #43 from abronkema/removeFromArray-README-update
...
updates function name to match exercise file
2019-11-27 09:18:12 -06:00
Cody Loyd
66c87fc01b
Merge branch 'master' into removeFromArray-README-update
2019-11-27 09:17:40 -06:00
Cody Loyd
e2f45971a3
Merge pull request #42 from HornMichaelS/master
...
Fix code indentation on helloWorld README.md
2019-11-27 09:16:30 -06:00
Cody Loyd
24b81e688e
Merge pull request #41 from Uzay-G/patch-1
...
Added ...rest parameters as a link to deal with optional parameters
2019-11-27 09:16:06 -06:00
Cody Loyd
99e3fa2fd3
Merge pull request #40 from nikolasbroman/patch-1
...
Fix typo
2019-11-27 09:15:15 -06:00
Cody Loyd
c2ca1d7acc
Merge pull request #36 from chrisjwelly/master
...
Add more tests for fibonacci
2019-11-27 09:14:33 -06:00
Cody Loyd
abcaeb918a
Merge pull request #35 from seoul2045/solutions
...
Reduce Method Solution
2019-11-27 09:13:51 -06:00
nearmint
235a6abdc1
Fix typo
2019-09-16 15:12:22 +02:00
Anthony Bronkema
6f30194d16
updates function name to match exercise file
2019-08-19 14:22:59 -04:00
Michael Horn
3d71a9ac1f
Fix code indentation on helloWorld README.md
2019-08-17 13:02:22 -07:00
Uzay G
46a36d8d09
Added ...rest parameters as a link to deal with optional parameters
...
Rest parameters are already arrays unlike 'arguments' and they can be used in arrow expressions. Just find it a bit simpler
2019-08-12 08:48:12 +00:00
Cody Loyd
cc479b5e70
Update README.md
2019-07-18 16:14:59 -05:00
Nikolas Broman
166baafbeb
Fix typo
2019-07-13 13:07:37 +03:00
Cody Loyd
4f07675184
Merge pull request #37 from TheOdinProject/I3uckwheat-patch-1
...
updates to show Odin directions
2019-06-12 11:46:01 -05:00
Briggs Elsperger
e0a0119979
updates to show Odin directions
2019-06-12 11:03:31 -05:00
Briggs Elsperger
a52257e5e0
Update README.md
2019-06-12 11:00:13 -05:00
Christian James Welly
347511516b
Add more tests for fibonacci
2019-05-24 08:23:24 +08:00
seoul2045
e93caf6368
Merge pull request #1 from seoul2045/reduce-method
...
Update calculator.js
2019-05-16 10:05:59 +07:00
seoul2045
645cbc746f
Update calculator.js
...
The reduce() method syntax for callbacks assigns the accumulator value followed by the currentValue, so I think the above variables should be switched.
2019-05-16 09:49:12 +07:00
Cody Loyd
01aace24b1
add titles solution
2019-04-11 12:14:20 -05:00
Cody Loyd
ffa00275cc
add findOldest Solutions
2019-04-11 12:11:03 -05:00
Cody Loyd
55e23a12af
Update README.md
2019-04-11 12:04:27 -05:00
Cody Loyd
25f9482bb1
Update README.md
2019-04-11 12:03:53 -05:00
Cody Loyd
05610c209c
Merge branch 'master' of github.com:TheOdinProject/javascript-exercises
2019-04-11 12:01:43 -05:00
Cody Loyd
9fe4861756
add 'find the oldest'
2019-04-11 12:00:21 -05:00
Cody Loyd
341661a100
add titles exercise
2019-04-11 11:37:33 -05:00
Cody Loyd
159d100c2b
Update README.md
2019-04-11 10:23:14 -05:00
Cody Loyd
c0ef28a362
add explanation and simpler solution to removeFromArray
2019-04-11 10:20:29 -05:00
Cody Loyd
a69e6ea689
Merge pull request #32 from TheOdinProject/update-packages
...
update packages
2019-03-15 08:15:26 -05:00
Austin Mason
dd98574efc
update packages
2019-03-01 21:05:57 +00:00
Briggs Elsperger
e455c78eb0
Fixes incorrect directions
2019-02-26 11:55:01 -06:00
Cody Loyd
b2e42072de
Merge pull request #30 from rickymccallum87/master
...
Clarify leap year rules
2019-02-06 17:35:34 -06:00
Ricky McCallum
b1ef1fa03a
Clarify leap year rules
2019-01-30 17:37:49 -05:00