dm-murphy
25f18760cc
Update caesar.spec.js
...
Proposing a change for caesar.spec.js for test 3 ('works with phrases') and test 4 ('works with negative shift'). The test for 'wraps' is supposed to come after these ones, but currently using the word "World!" in the earlier tests with a 5 key shift will require that wraps are already working, thus the spec test will fail even if the code is appropriate for phrases and negative shifts. If the learning process is to move one by one progressively through the spec tests, then I think it would be better not to require wraps to be working until the actual 'wraps' requirement in test 5. I believe simply replacing the word "World!" with "There!" should solve the issue.
2020-07-02 14:50:37 -04:00
Briggs Elsperger
888383a44e
Merge pull request #74 from imrogerjiang/new-tests
2020-05-09 12:16:42 -05:00
Roger
5817ea2140
Added blank string test to repeatString
2020-05-08 16:59:37 +10:00
Roger
3758497cb2
Added blank string test to reverseString
2020-05-08 16:56:55 +10:00
Roger
68691ab7a6
Added same type test to removeFromArray
2020-05-08 16:54:31 +10:00
Briggs Elsperger
c0d736a524
Merge pull request #73 from Timework/patch-1
2020-05-02 21:29:46 -05:00
Christopher Martinez
fb5677ee8f
Changed let to const and added some comments.
...
I changed the let to a const and added some explanation to how the test is conducted in comments included in the test.
2020-05-02 09:04:40 -05:00
Christopher Martinez
312103dc4f
Added random test
...
I added a random test getting a number from 1 to 1000. You said you wanted comments on it but I was not sure where to put them. I added the global modifier to the recommended regex in order for it count all the words properly.
2020-05-01 12:44:55 -05:00
Briggs Elsperger
26d610ca6e
Update README.md
2020-04-21 14:51:23 -06:00
Briggs Elsperger
9e2e2995e7
Update README.md
2020-04-21 14:51:06 -06:00
Cody Loyd
c61615f4bf
Merge pull request #64 from santimc/patch-1
...
Delete .DS_Store
2020-02-12 12:58:00 -06:00
santimc
ecc0872e96
Delete .DS_Store
2020-01-09 17:08:41 -03:00
Cody Loyd
f228d73f98
Merge pull request #45 from nearmint/patch-1
...
Fix typo
2019-11-27 09:18:56 -06:00
Cody Loyd
1d854ec580
Merge pull request #43 from abronkema/removeFromArray-README-update
...
updates function name to match exercise file
2019-11-27 09:18:12 -06:00
Cody Loyd
66c87fc01b
Merge branch 'master' into removeFromArray-README-update
2019-11-27 09:17:40 -06:00
Cody Loyd
e2f45971a3
Merge pull request #42 from HornMichaelS/master
...
Fix code indentation on helloWorld README.md
2019-11-27 09:16:30 -06:00
Cody Loyd
24b81e688e
Merge pull request #41 from Uzay-G/patch-1
...
Added ...rest parameters as a link to deal with optional parameters
2019-11-27 09:16:06 -06:00
Cody Loyd
99e3fa2fd3
Merge pull request #40 from nikolasbroman/patch-1
...
Fix typo
2019-11-27 09:15:15 -06:00
Cody Loyd
c2ca1d7acc
Merge pull request #36 from chrisjwelly/master
...
Add more tests for fibonacci
2019-11-27 09:14:33 -06:00
nearmint
235a6abdc1
Fix typo
2019-09-16 15:12:22 +02:00
Anthony Bronkema
6f30194d16
updates function name to match exercise file
2019-08-19 14:22:59 -04:00
Michael Horn
3d71a9ac1f
Fix code indentation on helloWorld README.md
2019-08-17 13:02:22 -07:00
Uzay G
46a36d8d09
Added ...rest parameters as a link to deal with optional parameters
...
Rest parameters are already arrays unlike 'arguments' and they can be used in arrow expressions. Just find it a bit simpler
2019-08-12 08:48:12 +00:00
Cody Loyd
cc479b5e70
Update README.md
2019-07-18 16:14:59 -05:00
Nikolas Broman
166baafbeb
Fix typo
2019-07-13 13:07:37 +03:00
Cody Loyd
4f07675184
Merge pull request #37 from TheOdinProject/I3uckwheat-patch-1
...
updates to show Odin directions
2019-06-12 11:46:01 -05:00
Briggs Elsperger
e0a0119979
updates to show Odin directions
2019-06-12 11:03:31 -05:00
Briggs Elsperger
a52257e5e0
Update README.md
2019-06-12 11:00:13 -05:00
Christian James Welly
347511516b
Add more tests for fibonacci
2019-05-24 08:23:24 +08:00
Cody Loyd
55e23a12af
Update README.md
2019-04-11 12:04:27 -05:00
Cody Loyd
25f9482bb1
Update README.md
2019-04-11 12:03:53 -05:00
Cody Loyd
05610c209c
Merge branch 'master' of github.com:TheOdinProject/javascript-exercises
2019-04-11 12:01:43 -05:00
Cody Loyd
9fe4861756
add 'find the oldest'
2019-04-11 12:00:21 -05:00
Cody Loyd
341661a100
add titles exercise
2019-04-11 11:37:33 -05:00
Cody Loyd
159d100c2b
Update README.md
2019-04-11 10:23:14 -05:00
Cody Loyd
a69e6ea689
Merge pull request #32 from TheOdinProject/update-packages
...
update packages
2019-03-15 08:15:26 -05:00
Austin Mason
dd98574efc
update packages
2019-03-01 21:05:57 +00:00
Briggs Elsperger
e455c78eb0
Fixes incorrect directions
2019-02-26 11:55:01 -06:00
Cody Loyd
b2e42072de
Merge pull request #30 from rickymccallum87/master
...
Clarify leap year rules
2019-02-06 17:35:34 -06:00
Ricky McCallum
b1ef1fa03a
Clarify leap year rules
2019-01-30 17:37:49 -05:00
Cody Loyd
6e0c5cdead
Merge pull request #29 from leila-alderman/patch-2
...
Change all but the first spec to pending
2019-01-11 15:10:18 -06:00
Cody Loyd
03d7ecf696
Merge pull request #28 from leila-alderman/patch-1
...
Update installation instructions
2019-01-11 15:08:40 -06:00
Leila Alderman
de6c2ff0ee
Remove Linux-specific wording
2018-12-14 16:45:04 -05:00
Leila Alderman
4a70d985b4
Change all but the first spec to pending
2018-12-08 19:38:09 -05:00
Leila Alderman
dfa97ee721
Update installation instructions
...
Added in a step for installing Node and clarified to not follow Linux's suggestions.
2018-12-03 18:04:31 -05:00
Kevin Mulhern
f3ac3d53c2
Merge pull request #27 from li3097/patch-1
...
Updated it
2018-10-10 13:08:20 +01:00
Lisa Tidball
370f88b9b8
Updated it
...
Changed tempConversion to repeatString since thats what this file is about.
2018-10-09 17:36:16 -04:00
Cody Loyd
29bd246dad
Merge pull request #19 from EBoisseauSierra/rewording-instructions
...
Rewording instructions
2018-08-07 08:06:55 -05:00
Étienne Boisseau-Sierra
00407bdee5
Transform 'let' in 'const' where needs be
2018-08-07 11:25:16 +01:00
Étienne Boisseau-Sierra
deb698c09e
Add test to caesar checking negative wraping cornercase
2018-08-07 11:25:16 +01:00