Commit Graph

376 Commits

Author SHA1 Message Date
Kevin Mulhern ee8f672bdd
Merge pull request #23 from bchalman/patch-1
Fix return value of recursiveFactorial function
2018-08-21 22:14:50 +01:00
bchalman b030e9a66b
Fix return value of recursive factorial function
While the previous return functioned the same (because it was calling another factorial function), it was not recursive. All credit still to ThirtyThreeB, just thought this might confuse some people and was worth fixing!
2018-08-19 13:02:55 -07:00
Cody Loyd 29bd246dad
Merge pull request #19 from EBoisseauSierra/rewording-instructions
Rewording instructions
2018-08-07 08:06:55 -05:00
Étienne Boisseau-Sierra 00407bdee5 Transform 'let' in 'const' where needs be 2018-08-07 11:25:16 +01:00
Étienne Boisseau-Sierra deb698c09e Add test to caesar checking negative wraping cornercase 2018-08-07 11:25:16 +01:00
Étienne Boisseau-Sierra ea595f1d10 Reword repeatString instructions 2018-08-07 11:25:16 +01:00
Étienne Boisseau-Sierra 35f797f454 Capitalize 'Hint'-subtitles 2018-08-07 11:25:16 +01:00
Étienne Boisseau-Sierra c17c207d0e Rephrase tempConversion instructions
- keep only main instructions above code sample (and move explanation about `module.exports` after the example)
- clarify that results should be rounded to one decimal place (as assume by tests)
2018-08-07 11:25:16 +01:00
Étienne Boisseau-Sierra 3a9251d55e Transform 'var' in 'let' 2018-08-07 11:25:16 +01:00
Cody Loyd b99fe58185
Merge pull request #21 from hoangtommy/master
add xit to problems for consistency
2018-07-24 15:48:23 -05:00
Cody Loyd 727e5f73b2
Merge pull request #20 from I3uckwheat/master
Changes node version to NPM
2018-07-24 15:47:59 -05:00
Tommy d4ac500896 add xit to problems on calc spec file so make it consistent with other exercises 2018-07-23 11:50:39 -07:00
Briggs Elsperger ec08e8c480
Changes node version to NPM
if a user does not have node he does not have NPM, but a user could have node without NPM
2018-07-11 23:35:06 -05:00
Kevin Mulhern 49f348ab1c
Merge pull request #15 from snakecase/patch-1
Remove repeating line
2018-04-17 15:11:45 +01:00
snakecase f9fdf07102
Remove repeating line 2018-04-01 11:22:02 +05:00
Cody Loyd 4ac1a8df01 remove simonsays 2018-03-01 13:14:00 -06:00
Cody Loyd 57b16f8cb0
Merge pull request #11 from jmooree30/patch-1
Update calculator.spec.js
2018-01-16 06:37:43 -06:00
Jacob C Moore e8f9821be6
Update calculator.spec.js 2018-01-13 12:34:10 -05:00
Cody Loyd b14ac4ea17
Merge pull request #9 from ThirtyThreeB/patch-1
Corrected solution to factorial function
2018-01-03 12:22:13 -06:00
Cody Loyd d63ee47dcb
Update calculator.js 2018-01-03 12:21:25 -06:00
ThirtyThreeB 83a2b6aead
Corrected solution to factorial function 2018-01-03 12:10:49 -05:00
Cody Loyd a16fd433bd
Merge pull request #7 from schoettkr/master
Adapt test description to the test
2018-01-02 08:48:16 -06:00
Cody Loyd 1e4013508d
Merge pull request #8 from Dareon4/master
zero factorial is 1
2018-01-02 08:47:47 -06:00
Jakub Broz 5c78dc7ebe zero factorial is 1 2018-01-01 15:56:20 +01:00
LS8 d0941673ee Adapt description to the test 2017-12-29 13:52:53 +01:00
Cody Loyd 9f4c1caf15
Merge pull request #5 from ryanford-frontend/patch-1
Add more granular instructions
2017-12-24 06:26:41 -06:00
Cody Loyd 35472494af
Merge pull request #4 from Nightcaper/patch-1
Update README.md
2017-12-24 06:26:28 -06:00
ryanford-frontend 26ecd35a83
Add more granular instructions
Instruct users to clone the repo in case that wasn't clear
2017-12-23 16:25:28 +08:00
Cody Loyd 950ab79d2b
Update README.md 2017-12-15 14:07:55 -06:00
Cody Loyd 35ed3d7b44 sumAll 2017-12-15 13:43:38 -06:00
Cody Loyd 02d2ca43f4 solutions 2017-12-15 13:26:05 -06:00
Cody Loyd 7facb382ac update gitignore 2017-12-15 12:57:30 -06:00
Cody Loyd 834d78b8b2 remove timer and simon 2017-12-15 12:56:14 -06:00
Cody Loyd 14cc7d40bd piglatin 2017-12-15 12:52:22 -06:00
Cody Loyd 956727d4e5 palindrome solution 2017-12-15 11:15:57 -06:00
Cody Loyd d42eebaab8 solutions 2017-12-15 11:01:24 -06:00
Cody Loyd 72878172b5 leap years solution 2017-12-14 15:35:45 -06:00
Cody Loyd 08c1a80f73
Update README.md 2017-12-05 20:36:48 -06:00
Nightcaper e4f5cbad75
Update README.md
Having to change 'xit's in exercises like repeatString for testing exercise solutions was not immediately obvious. I felt it should be mentioned so newbies before me won't face confusing jasmine messages about xits when testing their code.

I don't know how the wording of the readme is really intended, so I hope my change will address this properly.
2017-11-25 01:47:03 -06:00
Cody Loyd 0601b3663c Merge branch 'master' of github.com:TheOdinProject/javascript-exercises 2017-11-24 14:24:25 -06:00
Cody Loyd 08c3973e7b fix weird merge 2017-11-24 14:24:16 -06:00
Cody Loyd 829730fb79 Revert "remove class based exercises"
This reverts commit 290e7f1da4.
2017-11-24 14:23:16 -06:00
Cody Loyd 4d1f419b41 Revert "Update README.md"
This reverts commit f0bf584e59.
2017-11-24 14:22:47 -06:00
Cody Loyd 7de28f54fb
Update README.md 2017-11-24 14:18:11 -06:00
Cody Loyd 290e7f1da4 remove class based exercises 2017-11-20 13:51:01 -06:00
Cody Loyd c14e4628ec add solutions to first exercises 2017-11-04 23:03:44 -05:00
Cody Loyd f0bf584e59 Update README.md 2017-10-25 13:14:31 -05:00
Cody Loyd 4aec9d41fd Update tempConversion.spec.js 2017-10-25 11:53:33 -05:00
Cody Loyd afaa699ad1 Update leapYears.spec.js 2017-10-25 11:52:28 -05:00
Cody Loyd 2b524fb14d Merge pull request #3 from TheOdinProject/add-hints
add hints to exercises
2017-10-24 15:13:13 -05:00