tod
/
odin-default-js-exercises
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Inline codeSet and use const variable instead 

1) codeSet is not a good function name, since it includes no verb
2) extracting a const variable makes the function call redudant
   and shortens line 24 to be less than 80 characters wide
This commit is contained in:
c-auri 2022-11-18 16:17:40 +01:00
parent b4909d27a3
commit 7beb49e593
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
caesar/caesar.js
View File

@ -5,8 +5,6 @@ const caesar = function(string, shiftValue) {
.join(""); .join("");
}; };
const codeSet = code => (code < 97 ? 65 : 97);
// This function implements a version of the modulo operator // This function implements a version of the modulo operator
// that returns the smallest positive remainder even for negative inputs. // that returns the smallest positive remainder even for negative inputs.
// See this link for details: // See this link for details:
@ -17,7 +15,8 @@ const shift = (char, shiftValue) => {
const code = char.charCodeAt(); const code = char.charCodeAt();
if ((code >= 65 && code <= 90) || (code >= 97 && code <= 122)) { if ((code >= 65 && code <= 90) || (code >= 97 && code <= 122)) {
const shiftedCode = mod(code + shiftValue - codeSet(code), 26) + codeSet(code); const base = code < 97 ? 65 : 97;
const shiftedCode = mod(code + shiftValue - base, 26) + base;
return String.fromCharCode(shiftedCode); return String.fromCharCode(shiftedCode);
} }
return char; return char;