Commit Graph

310 Commits

Author SHA1 Message Date
jhylacey 74beb32038
Update README.md
The readme states "You will notice in this exercise that there are multiple tests, after making the first one pass, enable the others one by one by deleting the `.skip` in front the `test.skip()` function.", which is redundant and inconsistent. It's inconsistent because the previous exercise also including multiple tests, yet didn't include a blurb about multiple tests. It's redundant because it's already stated.
2023-03-09 15:18:16 -06:00
Kevin Mulhern ea1f23639c
Merge pull request #329 from TheOdinProject/test-workflow
Add circleci config file
2023-03-05 11:59:59 +00:00
01zulfi 99d0e8a71a Add circleci config file
* We can use circleci to test all spec files in solution subdirectories
2023-02-20 19:10:10 +05:00
Eric Olkowski 8dfb7e4508
Merge pull request #234 from thatblindgeye/update_solutions
Exercises: Add solution directories for all exercises
2023-02-20 08:42:44 -05:00
thatblindgeye e416717ba9 Remove test skips for solutions 2023-02-01 18:58:58 -05:00
thatblindgeye 2ec0f4344d Updated file paths 2023-02-01 18:53:54 -05:00
Eric Olkowski a092bf0559
Merge branch 'main' into update_solutions 2023-01-21 12:55:06 -05:00
thatblindgeye 4a112362c8 Update files 2023-01-21 12:53:41 -05:00
Eric Olkowski 8746ce056a
Merge pull request #299 from Asartea/asartea-patch-1
07_tempConversion: Update tempConversion function's naming
2022-11-19 10:39:52 -05:00
Asartea 9214f20afd restore initial test state 2022-11-12 21:07:47 +01:00
Asartea 0b218347ff Missed README.md 2022-11-12 20:59:52 +01:00
Asartea 374252c302 Update tempConversion function's naming 2022-11-12 20:49:28 +01:00
Rachel Moser a05d4d60c8
PR Template: Flip order of checklist and details (#289)
* PR Template: Flip order of checklist and details

Because:
If the details are first, they are viewable in Discord's webhook.

This PR:
* Moves the detail sections to the beginning of the template
* Moves the checklist section to the end of the template
* Adds an issue section to link the issue
* Adds the Because, This PR, and Issue sections to checklist
* Reduce wording that is not essential
2022-10-21 21:43:16 -05:00
Kevin Mulhern 0747078d97
Updated Installing Node JS lesson URL
Because:
* We have updated our lesson urls
2022-03-27 13:51:06 +01:00
Eric Olkowski 2586a8460c
Merge pull request #231 from TheOdinProject/thatblindgeye-patch-2
Templates: Create PR and Issue files
2022-02-22 17:01:28 -05:00
thatblindgeye fb1a2db8d7 Add solution directories for exercises 2022-02-20 14:07:44 -05:00
Eric Olkowski 649f0e3771
Update PULL_REQUEST_TEMPLATE.md 2022-02-20 13:25:26 -05:00
Eric Olkowski f82c72f760
Update bug_report.md 2022-02-20 13:21:49 -05:00
Eric Olkowski f002e3d6d0
Update feature_request.md 2022-02-20 13:20:37 -05:00
Eric Olkowski 1971712fde
Merge pull request #230 from TheOdinProject/thatblindgeye-patch-1
README: Make more consistent with other repos
2022-02-17 07:22:10 -05:00
Eric Olkowski 67d4d0afec
Update README.md 2022-02-16 22:01:13 -05:00
Eric Olkowski 076059551a
Update README.md 2022-02-16 17:41:44 -05:00
Eric Olkowski 2b54b1d682
Merge branch 'main' into thatblindgeye-patch-1 2022-02-16 17:26:00 -05:00
01zulfi 2ebbb5a925
Merge pull request #232 from jernestmyers/fix/update-readme
Remove irrelevant text from README about order of completion
2022-02-16 08:55:14 +05:00
Jeremy Myers edb9c244b5 Remove irrelevant text about order of completion 2022-02-14 16:05:00 -05:00
Eric Olkowski 417ee0d6e5
Create feature_request.md 2022-02-14 15:09:44 -05:00
Eric Olkowski baa5b0a761
Create bug_report.md 2022-02-14 15:09:20 -05:00
Eric Olkowski 6dd594c900
Create PULL_REQUEST_TEMPLATE.md 2022-02-14 15:07:50 -05:00
Eric Olkowski 1b43007a26
Update README.md 2022-02-14 14:59:03 -05:00
Michael Frank 2f9f431194
Merge pull request #227 from Mclilzee/main 2022-02-13 09:22:26 +13:00
Mclilzee 1acdfccb5d Fix palindromes false positive test 2022-02-08 20:52:06 +01:00
Michael Frank 82db5eac8b
Merge pull request #215 from programmurr/.../...new-node-install 2022-01-28 09:45:37 +13:00
Michael Frank efdfbd441c
Merge pull request #206 from chagstep1/patch-1 2022-01-27 14:32:10 +13:00
Michael Frank b1a0bf97c3
Merge pull request #193 from HiddenOgre28/main 2022-01-27 14:30:10 +13:00
conor 7a9377f675 Update NPM instruction to new lesson link 2022-01-18 21:09:59 +00:00
Austin 10044560cd
Merge pull request #210 from gerijeb/testFixing
Fix typo
2022-01-03 15:33:21 +00:00
gerijeb 09806f109a Fix typo 2022-01-01 21:50:35 -03:00
chagstep1 6527372e94
Remove predefined parameter from reverseString.js
Making it consistent with other exercise setups
2021-12-27 19:32:43 +03:00
HiddenOgre28 36e36b5278
Fixed a typo in line 41
Corrected the word "this" so it starts with an upper case "T".
2021-11-25 09:19:17 -03:00
Tatiana 6b0e0e55e3
Merge pull request #186 from mohammedsobhi/patch-1
fix 'says hello world' in README.md
2021-09-22 10:12:27 -07:00
Mohammed Sobhi e4f9675628
fix 'says hello world' in README.md
change 'says hello world'  to   'says "Hello, World!" ' to be identical to the code in the (helloWorld.spec.js) file.
2021-09-22 19:02:34 +02:00
Briggs Elsperger 2197f7b1b5
Merge pull request #183 from TheOdinProject/add-comments
add clarifiying comment about not removing code
2021-09-11 16:23:39 -06:00
Briggs Elsperger 74ab0b7cc6 add clarifiying comment about not removing code 2021-09-11 16:18:55 -06:00
Tatiana 0c5601ebd4
Merge pull request #181 from vishant-nambiar/fix/typo-in-caesar
Fixed typo in caesar cipher excersize
2021-08-31 22:35:50 -07:00
Vishant Nambiar cb083f5511 replaced semicolon with single quote in caesar 2021-08-29 19:43:34 +05:30
Tatiana 137636a425
Merge pull request #176 from msespos/edit-repeatstring-readme
Edit repeatstring readme
2021-08-13 08:59:21 -07:00
Mike Esposito 6274682cb5 Merge two bullet points in repeatString 2021-08-13 08:51:38 -07:00
Mike Esposito f0456531e4 Add paragraph to repeatString describing arguments 2021-08-13 08:46:05 -07:00
Tatiana 7ec76724d2
Merge pull request #171 from davidnth/patch-1
Update README.md
2021-08-07 22:17:18 -07:00
davidnth 702d983059
Update README.md
Co-authored-by: Tatiana <hello@tatianacodes.com>
2021-08-08 15:14:12 +10:00