tod
/
odin-default-js-exercises
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
281 Commits 18 Branches 0 Tags 7.2 MiB
Commit Graph

281 Commits

Author SHA1 Message Date
c-auri b4909d27a3 Extract const variable for readability 2022-11-18 16:52:37 +01:00
c-auri a539c1776a Improve modulo comment 
Technically, the % operator in JS is _not_ the modulo operator.
It's a different operator that returns negative values by design.
So it _does_ work with negative numbers as intended,
it's just not the operator that is needed for the caesar shift.
Therefore, mod does not "make % work with negative numbers",
it just uses % to implement the modulo operator.
The previous comment might suggest that there is a bug that gets fixed,
the new comment hopefully avoids that source of possible confusion.
 2022-11-18 15:43:29 +01:00
c-auri 0d27422bc5 Change shift variable and function names 
Using shift as a parameter name might be confusing,
since it is a verb and therefore not a good variable name on its own.
Changing it to shiftValue should clear things up and also makes it
possible to shorten the name of the shiftChar function to just shift,
which leads to a cleaner signature: shift(char, shiftValue)
 2022-11-18 14:53:38 +01:00
Tatiana db998d7279
Merge pull request #219 from tunsmart/solutions 
Improve the readability of the RegExp
 2022-01-30 10:28:53 -08:00
Babatunde Alli 4b13066369 Improve the readability of the RegExp 2022-01-28 18:23:16 -05:00
Michael Frank 7df108c5de
Merge pull request #216 from icorvus/solutions 2022-01-27 10:15:39 +13:00
icorvus de40b279df fixed semicolon 2022-01-23 21:17:39 +01:00
icorvus c09df52d6a fixed semicolon 2022-01-23 20:50:36 +01:00
Tatiana 8150be944b
Merge pull request #189 from Yasikhorram/fix-comment-contribution 
correct the term spread operator to rest operator + reduce the space between . and If
 2021-10-27 13:55:48 -07:00
Yasikhorram 5b5687862a correct the term spread operator to rest operator + reduce the space between . and If 2021-10-27 14:46:13 -05:00
Marvin Gay 56ebfc0f7d Merge branch 'main' into 'solutions' 2021-07-25 13:25:16 -04:00
Marvin Gay ebdc86a349
Merge pull request #133 from TheOdinProject/dependabot/npm_and_yarn/generator-exercise/y18n-3.2.2 
Bump y18n from 3.2.1 to 3.2.2 in /generator-exercise
 2021-07-24 12:52:37 -04:00
Marvin Gay a6298b0c07
Merge pull request #139 from TheOdinProject/dependabot/npm_and_yarn/generator-exercise/merge-1.2.1 
Bump merge from 1.2.0 to 1.2.1 in /generator-exercise
 2021-07-24 12:52:10 -04:00
Marvin Gay 3e774830f6
Merge pull request #140 from TheOdinProject/dependabot/npm_and_yarn/generator-exercise/handlebars-4.7.7 
Bump handlebars from 4.0.10 to 4.7.7 in /generator-exercise
 2021-07-24 12:51:37 -04:00
Marvin Gay d2677eed86
Merge pull request #165 from TheOdinProject/dependabot/npm_and_yarn/ws-7.5.3 
Bump ws from 7.4.5 to 7.5.3
 2021-07-24 12:50:43 -04:00
Marvin Gay b019348daa
Merge pull request #141 from TheOdinProject/dependabot/npm_and_yarn/generator-exercise/lodash-4.17.21 
Bump lodash from 4.17.4 to 4.17.21 in /generator-exercise
 2021-07-24 12:50:27 -04:00
dependabot[bot] 67bb819d63
Bump ws from 7.4.5 to 7.5.3 
Bumps [ws](https://github.com/websockets/ws) from 7.4.5 to 7.5.3.
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](https://github.com/websockets/ws/compare/7.4.5...7.5.3)

---
updated-dependencies:
- dependency-name: ws
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
 2021-07-24 16:49:59 +00:00
Marvin Gay 4ec0d5f424
Merge pull request #146 from TheOdinProject/dependabot/npm_and_yarn/generator-exercise/hosted-git-info-2.8.9 
Bump hosted-git-info from 2.5.0 to 2.8.9 in /generator-exercise
 2021-07-24 12:49:22 -04:00
Tatiana acca175d24
Update README.md 2021-07-10 21:42:57 -07:00
Tatiana 80affeb2a4
Update README.md 2021-07-10 14:53:40 -07:00
xandora 9c3bcb49f8
Merge pull request #156 from TheOdinProject/fix/hello-world-exercise 2021-05-29 14:51:10 +12:00
Michael Frank f8a2928882 Also update the actual spec file. 2021-05-29 07:55:43 +12:00
Michael Frank 50ce8d002c helloWorld.spec.js: Fix disparity between the README example and actual test. 2021-05-29 07:26:28 +12:00
xandora 778096f544
Merge pull request #154 from TheOdinProject/fix/clarify-jest-instructions 
Clarify Jest installation instructions
 2021-05-26 09:55:25 +12:00
xandora 6c713cf5f2
Minor syntax error 2021-05-21 13:13:55 +12:00
xandora 4355657732
Clarify Jest installation instructions 2021-05-21 12:14:57 +12:00
Kevin Mulhern 4fca2e249c
Merge pull request #150 from TheOdinProject/jest-solutions 
Implement Jest testing platform for all exercises (Solutions branch)
 2021-05-20 00:03:29 +01:00
xandora a2a7813159
Merge pull request #152 from TheOdinProject/chore/switch-to-jest 2021-05-19 20:54:09 +12:00
xandora c8857b8221
Ignore 'generator-exercise' folder when running npm test. 2021-05-18 12:26:46 +12:00
Kevin Mulhern fda681965e
Merge branch 'chore/switch-to-jest' into jest-solutions 2021-05-18 00:45:34 +01:00
xandora c8f3ff9d1b
Update helloWorld/helloWorld.js 
semicolon after function expression
 2021-05-18 11:43:45 +12:00
xandora 582521cc9f
Update calculator/calculator.js 
Fix duplicate semicolon
 2021-05-18 11:43:23 +12:00
xandora 71d3005e52
Update .gitignore 
New line at eof
 2021-05-18 11:43:10 +12:00
xandora 04bf93bb56
Update .eslintignore 
New line at eof
 2021-05-18 11:43:00 +12:00
Kevin Mulhern a1c56276ea Merge branch 'chore/switch-to-jest' into jest-solutions 2021-05-18 00:42:57 +01:00
Marvin Gay a0977c9295
Merge branch 'main' into km-testing-jest-2 2021-05-17 18:56:52 -04:00
Michael Frank 5708c3d85a Added jest 
Removed generator-exercises folder as it breaks jest-codemods

run jest-codemods on .spec.js files, move generator-exercises back in

Change references from Jasmine to Jest in main readme

Update README with Jest specific language. Update some spec files with new syntax

update tests, multiple exercises

.gitignore: Added package-lock.json, package.json that were used when I ran code-blocks over the tests.

Standardised function declaration calls across exercises

fix typo in caesar.spec.js

Ignoring package-lock.json, package.json

Backtrack on .gitignore modification, add instructions to readme

move files from testing repo to this repo

Typo fixes, remove duplicate exercise folder

Remove solution from non-solution branch

Minor grammatical fixes

added trailing semicolon to all function and module exports

Fix words caught by search/replace action.

remove doubled semicolon.

Correct words caught by search/replace action.

Add missing semicolon.

Add .DS_Store to .gitignore

multiple files: Added a blank line at the end of each file

Ignore generator-exercise when linting exercise files

Update exercise number of each exercise

Update exercise number
 2021-05-17 23:46:49 +01:00
Marvin Gay ad1c0c407f Revert "Merge branch 'jest'" 
This reverts commit f76e9e108f.
 2021-05-12 22:10:23 -04:00
Marvin Gay f76e9e108f Merge branch 'jest' 2021-05-12 21:47:42 -04:00
Marvin Gay 8430e59fe4 Merge branch 'origin/master' into 'jest' 2021-05-12 21:45:11 -04:00
Michael Frank 085fd89ec8 added new lines at end of file 2021-05-12 21:38:10 +12:00
Michael Frank 06e90f66c8 pulled eslint files from jester-tester and updated exercise numbers 2021-05-12 21:37:19 +12:00
Michael Frank 14f9b662de Update exercise number 2021-05-12 21:20:58 +12:00
Michael Frank 321e943041 Update exercise number of each exercise 2021-05-12 19:39:31 +12:00
Michael Frank 26ac56f75d Ignore generator-exercise when linting exercise files 2021-05-12 19:39:05 +12:00
Michael Frank 8b753de1d1 multiple files: Added a blank line at the end of each file 2021-05-12 19:37:53 +12:00
Michael Frank 03d7fe251a Add .DS_Store to .gitignore 2021-05-11 14:34:39 +12:00
Michael Frank 8546794b47 Remove lint script and add .DS_Store to .gitignore 2021-05-11 14:34:12 +12:00
Michael Frank 87e9d0eabc Add missing semicolon. 2021-05-11 14:29:44 +12:00
Michael Frank e454dfb35d Correct words caught by search/replace action. 2021-05-11 14:29:15 +12:00