tod
/
odin-default-js-exercises
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
371 Commits 18 Branches 0 Tags 7.2 MiB
Commit Graph

371 Commits

Author SHA1 Message Date
Mohd Abbas Haidar dd7078e1be Change name 
Changed name of directory generator-exercise to exercise-generator so that students don't confuse it for an exercise
 2023-08-20 23:49:29 +05:30
Manon dd9a83068d
Merge pull request #383 from RushilJalal/fix_Fibonacci_README 
10_fibonacci: Update README.md
 2023-08-01 14:27:55 +02:00
Rushil Jalal 43a8b165b4
Update 10_fibonacci/README.md 
Co-authored-by: Manon <81025586+ManonLef@users.noreply.github.com>
 2023-08-01 13:13:38 +05:30
Rushil Jalal 6d5f678ffc
Merge branch 'TheOdinProject:main' into fix_Fibonacci_README 2023-07-30 10:42:45 +05:30
Eric Olkowski cdba6da97b
Merge pull request #368 from cats256/patch-1 
Update sumAll-solution.js swap algorithm to standard method
 2023-07-29 17:38:39 -04:00
Will f5f6efae9b
Update sumAll-solution.js 2023-07-29 15:40:07 -05:00
Will 5513be576a
Update sumAll-solution.js 2023-07-29 15:39:33 -05:00
Rushil Jalal 631d24936b Update README.md 2023-07-28 19:49:32 +05:30
Rushil Jalal c9ad976fcb Update README.md 2023-07-28 19:32:21 +05:30
01zulfi 191a43a192
Merge pull request #340 from RyanMcEntire/getting_older_test_wording 
12_findTheOldest: Clarify test descriptions
 2023-07-27 18:11:47 +05:00
Eric Olkowski 2ca07161fd
Merge pull request #382 from RushilJalal/fix_Fibonacci_README 
10_fibonacci: Update README.md
 2023-07-25 07:00:10 -04:00
Rushil Jalal c77daf3fa9 Fix README.md Fibonacci series example 2023-07-24 23:37:21 +05:30
Eric Olkowski 9599e2ade3
Merge pull request #369 from cats256/cats256-branch 
Reformat test parameters for consistency
 2023-07-20 18:28:53 -04:00
Will 44e39f0412
Update calculator-solution.js 2023-07-16 16:06:25 -05:00
Will 1dae9df3ce
Update calculator-solution.spec.js 2023-07-16 16:02:28 -05:00
Will f855eb51b2
Update calculator-solution.spec.js 2023-07-16 16:02:03 -05:00
Will e10ee035ad
Update calculator.spec.js 2023-07-16 15:59:50 -05:00
Austin e3810865cf
Merge pull request #378 from Roberra0/ex12_ReadmeClarified 
Ex12 readme clarified
 2023-07-12 08:27:24 +01:00
Roberra Aklilu 100f952f7a
Update README.md with minor word change 2023-07-10 17:21:52 -07:00
Roberra Aklilu e6c4530aa9
Update ex12_findTheOldest README.md 
Added clarification to instruct learner to look in test case to understand object structure
 2023-07-10 17:09:29 -07:00
01zulfi 15f1b82b57
Merge pull request #370 from cats256/patch-2 
Update fibonacci-solution.js
 2023-07-07 08:47:24 +05:00
Nathan 51572a070c
Update fibonacci-solution.js 2023-07-06 09:47:20 -05:00
Austin f164d790da
Merge pull request #372 from Asartea/patch-1 
Fix: change requirement to reflect solutions change
 2023-07-06 09:11:44 +01:00
Nathan fcb1c4971a
Update fibonacci-solution.js 2023-07-05 09:15:36 -05:00
Asartea 051c0ed9ca
CONTRIBUTING.md: repoint contributing links to .github/CONTRIBUTING.md (#371) 
* repoint contributing links to .github/CONTRIBUTING.md

* drop mention of which repo it is
 2023-07-05 22:41:21 +10:00
Asartea bab1364ea8
Fix: change requirement to reflect solutions change 2023-07-05 13:50:13 +02:00
cats256 76551b0e8a
Update fibonacci-solution.js 
Better O(n) time
 2023-07-04 12:07:04 -05:00
cats256 03e52ea9ee Improve sum and multiply functions solution code 2023-07-04 11:55:08 -05:00
cats256 075fe8eea2 Reformat test parameters for consistency 2023-07-04 11:38:40 -05:00
cats256 3ecdab9531
Update sumAll-solution.js 2023-07-03 22:58:19 -05:00
cats256 415ff48c20
Update sumAll-solution.js 
Change the swapping algorithm to the standard way of swapping using array restructuring.
 2023-07-03 22:52:46 -05:00
Manon 5a7cd9b162
Merge pull request #367 from ManonLef/kbd 2023-07-02 09:01:22 +02:00
Manon 37f85db108 JS exercises README: change shortcuts to kbd format 2023-07-01 16:09:59 +02:00
Austin 61c86e11b6
Merge pull request #365 from Sama-004/patch-1 
`03_reverString: Updated README.md to add unskipping the skipped test cases`
 2023-06-28 14:22:37 +01:00
samanyu f98ee210e0
Made the file name sentence more readable 
Made changes according to the review, made the file name more readable and some minor grammatical changes.
 2023-06-28 17:34:00 +05:30
samanyu 5c1853e1e9
Updated README.md to add unskipping the skipped test cases 
Just like it was mentioned in the previous exercise to remove the .skip from test.skip() in the spec.js file.
 2023-06-28 08:43:15 +05:30
Cody Loyd 25013df6ac
Merge pull request #357 from marlatte/fibonacci_palindromes_fixes 
09_palindrome and 10_fibonacci: Update solutions
 2023-06-08 07:15:50 -05:00
Cody Loyd 8692f0ea18
Merge pull request #364 from fruddenfeldt/dev 
New solution to match updated test syntax
 2023-06-07 14:56:36 -05:00
fruddenfeldt 175ee761e1
Update calculator-solution.js 2023-06-07 19:58:54 +02:00
Cody Loyd 6b302e3783
Merge pull request #359 from fruddenfeldt/patch-1 
Removed array syntax in multiply test
 2023-06-07 08:45:00 -05:00
fruddenfeldt 80f7881a26
New solution to match updated test syntax 
See separate PR "Removed array syntax in multiply test #359"  

https://github.com/TheOdinProject/javascript-exercises/pull/359
 2023-06-06 23:01:36 +02:00
fruddenfeldt b6e9e2fac3
Removed array syntax in multiply test 
The test for the 'multiply' function used array brackets [] for the input parameters, which caused the test to return an error when rest parameters (...args) are used in the function, like so:

const multiply = function(...args){
  return args.reduce((acc, cur) => acc * cur);
}
 2023-05-22 21:08:37 +02:00
MarLatte fd1e1f93d1 Merge branch 'fibonacci_palindromes_fixes' of github.com:marlatte/javascript-exercises into fibonacci_palindromes_fixes 2023-05-20 03:10:37 -04:00
MarLatte 0d75cc0814 Update palindrome test to match solution test 2023-05-20 03:07:57 -04:00
MarLatte e8fc8ce41e Update palindromes to handle numbers better 
The previous solution removed numbers entirely, whereas this one treats
them like letters and checks if they are evenly spaced.

More importantly, the old solution test seemed to check if the numbers
were palindromic, but because the solution replaced them with "", it
wasn't testing what it seemed to.

I added a new test to differentiate between the palindromic "rac3e3car"
and the non-palindromic "r3ace3car".

These changes also obviate the problems raised in Issue #355.
 2023-05-20 02:47:17 -04:00
MarLatte 41380593f7 Update palindromes to handle numbers better 
The previous solution removed numbers entirely, whereas this one treats
them like letters and checks if they are evenly spaced.

More importantly, the old solution test seemed to check if the numbers
were palindromic, but because the solution replaced them with "", it
wasn't testing what it seemed to.

I added a new test to differentiate between the palindromic "rac3e3car"
and the non-palindromic "r3ace3car".
 2023-05-20 02:37:41 -04:00
MarLatte 3256f980b0 Update Fibonacci solution, test to focus on arrays 
Previous Fibonacci solution didn't use arrays, and since this is an
array-heavy section, it seemed better to have that be the method here.

Also, it accounts for entering 0 as an argument without having to add
any extra code, which takes care of some currently open issues.
Issues #192 and #236 are about the same thing.

I added a test for that as well.
 2023-05-20 02:22:12 -04:00
Eric Olkowski 3e530e3f61
Merge pull request #341 from thatblindgeye/updatePalindromes 
09_palindromes: update solution test file
 2023-04-08 15:51:19 -04:00
Eric Olkowski 6bb8b1397d
Merge pull request #321 from Alex-Nemet/fix_typo_readme 
Readme.md: fix spelling
 2023-04-08 15:48:15 -04:00
thatblindgeye 045f1b0306 Update solutions file for palindrome 2023-04-08 15:44:15 -04:00