tod
/
odin-default-js-exercises
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
349 Commits 18 Branches 0 Tags 7.2 MiB
Commit Graph

349 Commits

Author SHA1 Message Date
Austin e3810865cf
Merge pull request #378 from Roberra0/ex12_ReadmeClarified 
Ex12 readme clarified
 2023-07-12 08:27:24 +01:00
Roberra Aklilu 100f952f7a
Update README.md with minor word change 2023-07-10 17:21:52 -07:00
Roberra Aklilu e6c4530aa9
Update ex12_findTheOldest README.md 
Added clarification to instruct learner to look in test case to understand object structure
 2023-07-10 17:09:29 -07:00
01zulfi 15f1b82b57
Merge pull request #370 from cats256/patch-2 
Update fibonacci-solution.js
 2023-07-07 08:47:24 +05:00
Nathan 51572a070c
Update fibonacci-solution.js 2023-07-06 09:47:20 -05:00
Austin f164d790da
Merge pull request #372 from Asartea/patch-1 
Fix: change requirement to reflect solutions change
 2023-07-06 09:11:44 +01:00
Nathan fcb1c4971a
Update fibonacci-solution.js 2023-07-05 09:15:36 -05:00
Asartea 051c0ed9ca
CONTRIBUTING.md: repoint contributing links to .github/CONTRIBUTING.md (#371) 
* repoint contributing links to .github/CONTRIBUTING.md

* drop mention of which repo it is
 2023-07-05 22:41:21 +10:00
Asartea bab1364ea8
Fix: change requirement to reflect solutions change 2023-07-05 13:50:13 +02:00
cats256 76551b0e8a
Update fibonacci-solution.js 
Better O(n) time
 2023-07-04 12:07:04 -05:00
Manon 5a7cd9b162
Merge pull request #367 from ManonLef/kbd 2023-07-02 09:01:22 +02:00
Manon 37f85db108 JS exercises README: change shortcuts to kbd format 2023-07-01 16:09:59 +02:00
Austin 61c86e11b6
Merge pull request #365 from Sama-004/patch-1 
`03_reverString: Updated README.md to add unskipping the skipped test cases`
 2023-06-28 14:22:37 +01:00
samanyu f98ee210e0
Made the file name sentence more readable 
Made changes according to the review, made the file name more readable and some minor grammatical changes.
 2023-06-28 17:34:00 +05:30
samanyu 5c1853e1e9
Updated README.md to add unskipping the skipped test cases 
Just like it was mentioned in the previous exercise to remove the .skip from test.skip() in the spec.js file.
 2023-06-28 08:43:15 +05:30
Cody Loyd 25013df6ac
Merge pull request #357 from marlatte/fibonacci_palindromes_fixes 
09_palindrome and 10_fibonacci: Update solutions
 2023-06-08 07:15:50 -05:00
Cody Loyd 8692f0ea18
Merge pull request #364 from fruddenfeldt/dev 
New solution to match updated test syntax
 2023-06-07 14:56:36 -05:00
fruddenfeldt 175ee761e1
Update calculator-solution.js 2023-06-07 19:58:54 +02:00
Cody Loyd 6b302e3783
Merge pull request #359 from fruddenfeldt/patch-1 
Removed array syntax in multiply test
 2023-06-07 08:45:00 -05:00
fruddenfeldt 80f7881a26
New solution to match updated test syntax 
See separate PR "Removed array syntax in multiply test #359"  

https://github.com/TheOdinProject/javascript-exercises/pull/359
 2023-06-06 23:01:36 +02:00
fruddenfeldt b6e9e2fac3
Removed array syntax in multiply test 
The test for the 'multiply' function used array brackets [] for the input parameters, which caused the test to return an error when rest parameters (...args) are used in the function, like so:

const multiply = function(...args){
  return args.reduce((acc, cur) => acc * cur);
}
 2023-05-22 21:08:37 +02:00
MarLatte fd1e1f93d1 Merge branch 'fibonacci_palindromes_fixes' of github.com:marlatte/javascript-exercises into fibonacci_palindromes_fixes 2023-05-20 03:10:37 -04:00
MarLatte 0d75cc0814 Update palindrome test to match solution test 2023-05-20 03:07:57 -04:00
MarLatte e8fc8ce41e Update palindromes to handle numbers better 
The previous solution removed numbers entirely, whereas this one treats
them like letters and checks if they are evenly spaced.

More importantly, the old solution test seemed to check if the numbers
were palindromic, but because the solution replaced them with "", it
wasn't testing what it seemed to.

I added a new test to differentiate between the palindromic "rac3e3car"
and the non-palindromic "r3ace3car".

These changes also obviate the problems raised in Issue #355.
 2023-05-20 02:47:17 -04:00
MarLatte 41380593f7 Update palindromes to handle numbers better 
The previous solution removed numbers entirely, whereas this one treats
them like letters and checks if they are evenly spaced.

More importantly, the old solution test seemed to check if the numbers
were palindromic, but because the solution replaced them with "", it
wasn't testing what it seemed to.

I added a new test to differentiate between the palindromic "rac3e3car"
and the non-palindromic "r3ace3car".
 2023-05-20 02:37:41 -04:00
MarLatte 3256f980b0 Update Fibonacci solution, test to focus on arrays 
Previous Fibonacci solution didn't use arrays, and since this is an
array-heavy section, it seemed better to have that be the method here.

Also, it accounts for entering 0 as an argument without having to add
any extra code, which takes care of some currently open issues.
Issues #192 and #236 are about the same thing.

I added a test for that as well.
 2023-05-20 02:22:12 -04:00
Eric Olkowski 3e530e3f61
Merge pull request #341 from thatblindgeye/updatePalindromes 
09_palindromes: update solution test file
 2023-04-08 15:51:19 -04:00
Eric Olkowski 6bb8b1397d
Merge pull request #321 from Alex-Nemet/fix_typo_readme 
Readme.md: fix spelling
 2023-04-08 15:48:15 -04:00
thatblindgeye 045f1b0306 Update solutions file for palindrome 2023-04-08 15:44:15 -04:00
Eric Olkowski 34d63cc59d
Merge pull request #320 from mariustelcean96/patch-2 
09_palindromes: Add test for strings with numbers
 2023-04-08 15:42:52 -04:00
Kevin Mulhern 029cf3ffcd
Merge pull request #338 from TheOdinProject/KevinMulhern-patch-2 
Create LICENSE
 2023-03-28 08:26:14 +01:00
Kevin Mulhern 378921289b
Create LICENSE 
Because:
* This repo does not have a licence

This commit:
* Add the MIT licence
 2023-03-25 15:49:30 +00:00
Kevin Mulhern cface9db19
Merge pull request #337 from TheOdinProject/revert-license 
Revert "Create LICENSE"
 2023-03-25 15:48:02 +00:00
Kevin 736cae8b06 Revert "Create LICENSE" 
This reverts commit e63e0bf296.
 2023-03-25 15:46:09 +00:00
Kevin Mulhern e63e0bf296
Create LICENSE 
Because:
* This repo did not have a licence

This commit:
* Add MIT Licence
 2023-03-25 15:44:27 +00:00
Alex-Nemet 614b8b8c35
Merge branch 'main' into fix_typo_readme 2023-03-22 12:59:21 -07:00
Asartea 75869d1912
Mark caesar as archived and move archived exercise to own folder (#336) 2023-03-18 16:45:37 -05:00
jhylacey 6f5f71ff5b
Remove redundant wording in reverse string README 2023-03-18 14:14:44 -05:00
Kevin Mulhern ea1f23639c
Merge pull request #329 from TheOdinProject/test-workflow 
Add circleci config file
 2023-03-05 11:59:59 +00:00
01zulfi 99d0e8a71a Add circleci config file 
* We can use circleci to test all spec files in solution subdirectories
 2023-02-20 19:10:10 +05:00
Eric Olkowski 8dfb7e4508
Merge pull request #234 from thatblindgeye/update_solutions 
Exercises: Add solution directories for all exercises
 2023-02-20 08:42:44 -05:00
thatblindgeye e416717ba9 Remove test skips for solutions 2023-02-01 18:58:58 -05:00
thatblindgeye 2ec0f4344d Updated file paths 2023-02-01 18:53:54 -05:00
Alex Nemet 84d537f130 Correct minor spelling error 2023-01-29 18:10:11 -04:00
Telcean Marius-Andrei 83d3dcd1dd
Add test for strings with numbers 
Proposed by @thatblindgeye.
 2023-01-28 16:26:19 +02:00
Eric Olkowski a092bf0559
Merge branch 'main' into update_solutions 2023-01-21 12:55:06 -05:00
thatblindgeye 4a112362c8 Update files 2023-01-21 12:53:41 -05:00
Eric Olkowski 8746ce056a
Merge pull request #299 from Asartea/asartea-patch-1 
07_tempConversion: Update tempConversion function's naming
 2022-11-19 10:39:52 -05:00
Asartea 9214f20afd restore initial test state 2022-11-12 21:07:47 +01:00
Asartea 0b218347ff Missed README.md 2022-11-12 20:59:52 +01:00